-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few additions to the README.md #1144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My review is not complete, yet. I'm busy elsewhere. |
I clicked resolve. Was it the correct option? Thanks for the formatting and other stuff. @farooqkz , what's LCTM? |
No you clicked the wrong button :) You should commit my suggestions if you agree with them. |
Oh lel. I am on phone so I might need to navigate a bit more. |
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
I switched to my browser and committed some changes. Did it work? ^π^ |
Yes but more review is required. Also I appreciate your work and effort. Hopefully, you'll learn Lua and contribute code as well :) |
Yes, more work has to be done. Thanks :D. |
Btw I did learn Lua. I just have to start with Minetest modding basics whenever I get sufficient time. |
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Removing line. Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
@a-blob I have added this line instead of the method that wasted the placement of the corners etc.:
I suppose it is obvious that the maker has to repeat the process for every edit they make onwards? |
Co-authored-by: LoneWolfHT <lonewolf04361@gmail.com>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
I have made some changes, so I request a review. Also, is there anything stopping the merge of this PR or is it that it is still incomplete? |
…changed; Changing a line to inclue the Resume option
Some extra information and clarifying edits.